96215[TASK] Extract the extension scanner into a service
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 17
- typo3/sysext/install/Classes/Controller/UpgradeController.php+35 −189
- typo3/sysext/install/Classes/ExtensionScanner/Php/MatcherRegistry.php3new+159 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/Indicator.phpnew+35 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/ScanMatch.php2new+73 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/ScanResult.phpnew+81 −0
- typo3/sysext/install/Classes/ExtensionScanner/ExtensionScannerService.php3new+228 −0
- typo3/sysext/install/Classes/ServiceProvider.php+10 −0
- typo3/sysext/install/Tests/Functional/Controller/UpgradeControllerTest.phpnew+251 −0
- typo3/sysext/install/Tests/Functional/UpgradeAnalysis/DocumentationFileTest.php+18 −0
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+66 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/BrokenSyntaxFixture.txtnew+5 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/IgnoredFileFixture.phpnew+31 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/RemovedFixtureClass.php3new+24 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/ScanFixture.phpnew+35 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/MatcherRegistryTest.phpnew+54 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Result/ScanResultTest.phpnew+75 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/ExtensionScannerServiceTest.php2new+200 −0
Review log 2126
Show 1 earlier messages
-
Olivier Dobberkau uploaded patch set 1 09/30/26, 11:53
-
core-ci voted on patch set 1 V -1 09/30/26, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109619
-
Garvin Hicking commented on patch set 1 09/30/26, 13:59
-
Benni Mack commented on patch set 1 09/30/26, 15:06
I don't consider this a Feature yet, but rather a pre-patch and refactoring, which could also go into v14 as well. -
Benni Mack commented on patch set 1 09/30/26, 15:07
RemovedFixtureClass.php:3please add our standard header for PHP files. also below for all new PHP files -
Olivier Dobberkau uploaded patch set 2
V -109/30/26, 15:41 -
core-ci voted on patch set 2 V -1 09/30/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109665
-
Mathias Brodala commented on patch set 2 10/01/26, 07:15
ExtensionScannerService.php:47Tiny nitpick: why not simply "ExtensionScanner"? -
Olivier Dobberkau uploaded patch set 3
V -110/01/26, 21:10 -
core-ci voted on patch set 3 V +1 10/01/26, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109842
-
Olivier Dobberkau commented on patch set 3 10/01/26, 21:36
AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed every line of the diff, ran unit, functional, phpstan and cgl locally and take responsibility for this change. Patch set 3 addresses the review: it is now a [TASK] with its own issue #110877, all new classes are @internal and the Feature rst is gone. Releases: main, 14.3. As 14.3 requires PHP 8.2, the backport will be an adapted patch once main is merged. #110859 stays with the console command in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96216. -
Olivier Dobberkau commented on patch set 3 10/01/26, 21:43
Reply
Agreed, thanks. Turned into a [TASK] (#110877), internal only, with Releases: main, 14.3. See the patch set comment for the backport.ExtensionScannerService.php:47ReplyExtensionScanner is already the namespace, so the class would be ExtensionScanner\ExtensionScanner. The Service suffix avoids that and matches the neighbouring …Service classes of EXT:install (ClearCacheService, CoreVersionService, LateBootService, …).MatcherRegistry.php:60ReplyGood point. With patch set 3 the service and MatcherRegistry are @internal, so no public API is created here. A tagged service plus service locator, so that extensions can contribute matchers, deserves its own change; I'd do it as a follow-up and keep this one a pure refactoring that can be backported.RemovedFixtureClass.php:3ReplyDone in patch set 2: all new PHP files, fixtures included, carry the standard header. -
Olivier Dobberkau commented on patch set 3 10/01/26, 21:48
Reply
AcknowledgedExtensionScannerService.php:47ReplyAcknowledgedRemovedFixtureClass.php:3ReplyAcknowledged -
Olivier Dobberkau commented on patch set 3 10/01/26, 21:50
Reply
Acknowledged -
Simon Schaufelberger commented on patch set 3 10/01/26, 23:57
ScanMatch.php:33the indentation doesn't look right. I guess one less white space so that it aligns well with Opaque?ExtensionScannerServiceTest.php:36i would move private methods all the way to the end of the file -
Garvin Hicking commented on patch set 3 10/02/26, 05:29
MatcherRegistry.php:60ReplyAgreed, thanks! -
Olivier Dobberkau uploaded patch set 4
V +110/02/26, 07:42 -
core-ci voted on patch set 4 V +1 10/02/26, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109886
-
Simon Schaufelberger commented on patch set 4 CR +1 V +1 10/02/26, 09:57
ScanMatch.php:33ReplyDoneExtensionScannerServiceTest.php:36ReplyDone -
Garvin Hicking uploaded patch set 5
CR +1V +110/02/26, 11:03 -
Garvin Hicking commented on patch set 5 CR +1 V +1 10/02/26, 11:03
Reply
Done -
Olivier Dobberkau commented on patch set 5 10/02/26, 11:07
Reply
Thanks for patch set 5, Garvin, especially for fixing the misplaced @internal docblock. -
core-ci voted on patch set 5 V +1 10/02/26, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109919
-
Garvin Hicking commented on patch set 5 10/02/26, 11:23
Reply
Thanks for pushing this forward. This was something I had on my wishlist for a long time, to be able to re-use these component. Hope it carries. 😊 -
Benni Mack voted on patch set 5 CR +2 V +2 10/07/26, 15:32
-
Benni Mack merged patch set 6 10/07/26, 15:32
MatcherRegistry.php:60