Issue Task Resolved

#110877Extract the extension scanner into a service

Olivier Dobberkau 10/01/26, 21:00 updated 10/07/26, 19:15

Description

Why: The extension scanner is only reachable through the install tool. The scan loop sits inline in UpgradeController::extensionScannerScanFileAction(), and the 23 matchers are a hardcoded property of the same controller. No other caller, such as the planned upgrade:scan console command (#110859), can reuse them.

What: Move the matcher registry into its own class and the scan into an ExtensionScannerService that returns typed results (ScanResult, ScanMatch, Indicator enum). All classes are @internal; there is no public API change. The output of the “Scan Extension Files” card stays the same.

I will create a patch for this.

Reviews 2

History 27

  1. Olivier Dobberkau commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-10-07T15:35:08+00:00" > 10/07/26, 15:35 </span>

    Applied in changeset commit:8d601385b7abe36204529d27364d8ef7a271ac4d.

  2. Gerrit Code Review pushed patch set 2 for 14.3 to change 96489 status Resolved Under Review <span data-processor="relativetime" data-value="2026-10-07T18:41:31+00:00" > 10/07/26, 18:41 </span>

  3. Olivier Dobberkau commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-10-07T19:15:10+00:00" > 10/07/26, 19:15 </span>

    Applied in changeset commit:f3b14506cb4b46d4b6429bb3483a682a1e93e44d.