Review main Merged

96234[TASK] Document record collection side effects

Wouter Wolters CR +2 V +2 Easy +3 −13 updated 10/09/26, 19:12

Commit message

Mark the source and category collectors as impure for PHPStan. They
populate the record data through side effects. Analysis must respect
these instead of treating it as an empty array throughout render().

Keep the overlay guards and runtime behavior unchanged and remove the
corresponding baseline entries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Wouter Wolters uploaded patch set 1 09/30/26, 20:20

  2. Wouter Wolters uploaded patch set 2 09/30/26, 21:25

  3. Wouter Wolters commented on patch set 3 09/30/26, 21:44

    Published edit on patch set 2.
  4. Wouter Wolters updated the commit message in patch set 4 10/09/26, 18:30

  5. Wouter Wolters rebased onto patch set 5 10/09/26, 18:31

  6. Wouter Wolters wrote 10/09/26, 18:31

    Unset private
  7. Wouter Wolters marked it ready for review 10/09/26, 18:31

  8. core-ci voted on patch set 5 V -1 10/09/26, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110681

  9. core-ci voted on patch set 5 V +1 10/09/26, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110681

  10. Benni Mack voted on patch set 5 CR +2 V +2 10/09/26, 19:12

  11. Benni Mack merged patch set 6 10/09/26, 19:12