#111002Document record collection side effects
Description
Mark the source and category collectors as impure for PHPStan. They
populate the record data through side effects. Analysis must respect
these instead of treating it as an empty array throughout render().
Keep the overlay guards and runtime behavior unchanged and remove the
corresponding baseline entries.
Reviews 1
History 13
-
Gerrit Code Review pushed patch set 4 for main to change 96234 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-09T18:31:01+00:00" > 10/09/26, 18:31 </span> -
Gerrit Code Review pushed patch set 5 for main to change 96234 <span data-processor="relativetime" data-value="2026-10-09T18:31:04+00:00" > 10/09/26, 18:31 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-09T19:20:10+00:00" > 10/09/26, 19:20 </span>
Applied in changeset commit:7965263c0daaf4aafbd119c0a8bd78a8385ce148.