Review main Merged

96274[TASK] Remove redundant authentication logging fallback

Wouter Wolters CR +2 V +2 Easy +21 −7 updated 10/12/26, 06:44

Commit message

The parent authentication object's writeAttemptLog preference is
documented as bool, and core assigns only boolean values. Copy the
preference directly instead of applying an unreachable null fallback.

Keep the boolean contract, cover enabled and disabled logging in unit
tests, and remove the corresponding PHPStan baseline occurrence.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1720

  1. Wouter Wolters uploaded patch set 1 10/01/26, 19:10

  2. Wouter Wolters rebased onto patch set 2 10/09/26, 16:37

  3. Wouter Wolters updated the commit message in patch set 3 10/09/26, 16:37

  4. Wouter Wolters wrote 10/09/26, 16:37

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 16:37

  6. core-ci voted on patch set 2 V +1 10/09/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110646

  7. core-ci voted on patch set 3 V +1 10/09/26, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110647

  8. Josua Vogel voted on patch set 3 CR +1 10/10/26, 07:00

  9. Oliver Klee voted on patch set 3 CR +1 V +1 10/10/26, 08:28

  10. Oli Bartsch commented on patch set 3 10/10/26, 08:39

    Where is $writeAttemptLog set to null and why should that be supported? I think bool should be the only possible value for $writeAttemptLog.
  11. Wouter Wolters uploaded patch set 4 CR +1 V +1 10/10/26, 18:35

  12. core-ci voted on patch set 4 V +1 10/10/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110812

  13. Oliver Klee voted on patch set 4 CR +1 V +1 10/10/26, 19:11

  14. Andreas Kienast commented on patch set 4 10/10/26, 19:19

    Reply

    Can you please elaborate? The old code had an unnecessary null coalesce handling (hence the baseline entry), which is now removed. What do I miss?
  15. Wouter Wolters commented on patch set 4 10/10/26, 19:47

    Reply

    I fixed it after Oli his comment.
  16. Andreas Kienast commented on patch set 4 10/10/26, 20:03

    Reply

    Thanks, I missed that there was a push in between. Sorry for the noise.
  17. Andreas Kienast voted on patch set 4 CR +1 V +1 10/10/26, 20:04

  18. Josua Vogel voted on patch set 4 CR +1 V +1 10/12/26, 06:19

  19. Benni Mack voted on patch set 4 CR +2 V +2 10/12/26, 06:44

  20. Benni Mack merged patch set 5 10/12/26, 06:44