96274[TASK] Remove redundant authentication logging fallback
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Josua Vogel +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Josua Vogel +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1720
-
Wouter Wolters uploaded patch set 1 10/01/26, 19:10
-
Wouter Wolters rebased onto patch set 2 10/09/26, 16:37
-
Wouter Wolters updated the commit message in patch set 3 10/09/26, 16:37
-
Wouter Wolters wrote 10/09/26, 16:37
Unset private -
Wouter Wolters marked it ready for review 10/09/26, 16:37
-
core-ci voted on patch set 2 V +1 10/09/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110646
-
core-ci voted on patch set 3 V +1 10/09/26, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110647
-
Josua Vogel voted on patch set 3 CR +1 10/10/26, 07:00
-
Oliver Klee voted on patch set 3 CR +1 V +1 10/10/26, 08:28
-
Oli Bartsch commented on patch set 3 10/10/26, 08:39
Where is $writeAttemptLog set to null and why should that be supported? I think bool should be the only possible value for $writeAttemptLog. -
Wouter Wolters uploaded patch set 4
CR +1V +110/10/26, 18:35 -
core-ci voted on patch set 4 V +1 10/10/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110812
-
Oliver Klee voted on patch set 4 CR +1 V +1 10/10/26, 19:11
-
Andreas Kienast commented on patch set 4 10/10/26, 19:19
Reply
Can you please elaborate? The old code had an unnecessary null coalesce handling (hence the baseline entry), which is now removed. What do I miss? -
Wouter Wolters commented on patch set 4 10/10/26, 19:47
Reply
I fixed it after Oli his comment. -
Andreas Kienast commented on patch set 4 10/10/26, 20:03
Reply
Thanks, I missed that there was a push in between. Sorry for the noise. -
Andreas Kienast voted on patch set 4 CR +1 V +1 10/10/26, 20:04
-
Josua Vogel voted on patch set 4 CR +1 V +1 10/12/26, 06:19
-
Benni Mack voted on patch set 4 CR +2 V +2 10/12/26, 06:44
-
Benni Mack merged patch set 5 10/12/26, 06:44