#110989Document nullable authentication logging preferences
Description
AbstractAuthenticationService defaults to logging failed attempts
when the parent authentication object has a null writeAttemptLog
preference. The public untyped property already supports this case,
but its PHPDoc only documents bool.
Document bool|null and preserve the existing null-coalescing fallback.
Cover true, false and null preferences in unit tests and remove the
matching PHPStan baseline occurrence. Runtime behavior is unchanged.
Reviews 1
History 13
-
Gerrit Code Review pushed patch set 3 for main to change 96274 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-09T16:37:34+00:00" > 10/09/26, 16:37 </span> -
Gerrit Code Review pushed patch set 4 for main to change 96274 <span data-processor="relativetime" data-value="2026-10-10T18:35:14+00:00" > 10/10/26, 18:35 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-12T06:50:14+00:00" > 10/12/26, 06:50 </span>
Applied in changeset commit:d1dbd4529a4abc727ee6858a7840307a36c73bc9.