Review 14.3 Merged

96276[BUGFIX] Prevent record actions on paginator enter

Oli Bartsch CR +2 V +2 Normal +200 −49 updated 10/01/26, 20:38

Commit message

Since the record actions in the list module are rendered via
GenericButton and DropDownItem, they lack an explicit button type
and thus act as submit buttons. Pressing enter in the paginator
input therefore triggered the implicit form submission, which
activated the first action of the first record, e.g. the
hide/unhide toggle or the info window.

GenericButton and dropdown items now render type="button" for
button tags, unless a type is set explicitly. The "show" title
link button gets an explicit type as well. Additionally, the
paginator input prevents the implicit form submission on keydown.

The helper to set user TSconfig in e2e tests is extracted to be
reused by the new pagination test.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 46

  1. Oli Bartsch commented on patch set 1 10/01/26, 19:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/01/26, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109835

  3. Oli Bartsch uploaded patch set 2 V -1 10/01/26, 20:26

  4. core-ci voted on patch set 2 V +1 10/01/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109836

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 10/01/26, 20:38

  6. Oli Bartsch merged patch set 3 10/01/26, 20:38