Review 14.3 Merged

96277[BUGFIX] Fix issue where editors cannot enable or disable redirects

Oli Bartsch CR +2 V +2 Normal +110 −1 updated 10/01/26, 20:38

Commit message

DataHandlerPermissionGuardHook validates a sys_redirect update by
checking the incoming field array's source_host and target against the
current backend user's allowed hosts and targets. When the record list's
enable/disable toggle updates a redirect, DataHandler only submits the
single changed field, so source_host and target are absent from that
array and are treated as empty strings, which never match an allowed
host. Editing the full record works because FormEngine always submits
source_host and target along with it, so only the list view toggle was
affected.

The hook now falls back to the persisted source_host and target of the
existing record when they are missing from the incoming field array,
so partial updates are validated against the redirect's actual values
instead of empty strings, while the permission check still applies to
whichever fields the update actually changes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Oli Bartsch commented on patch set 1 10/01/26, 20:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/01/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109837

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/01/26, 20:38

  4. Oli Bartsch merged patch set 2 10/01/26, 20:38