Review 14.3 Merged

96293[BUGFIX] Ignore mime type parameters for video/audio tag renderer

Garvin Hicking CR +2 V +2 Easy +16 −4 updated 10/02/26, 08:57

Commit message

File mime types may have parameters according to RFC 9110, section
8.3.1, e.g. `video/mp4;codecs="avc1.42E01E"`, and are
case-insensitive. Ignore the parameters and the case when detecting
whether a file can be rendered.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Garvin Hicking commented on patch set 1 10/02/26, 05:12

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php * typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php
  2. core-ci voted on patch set 1 V -1 10/02/26, 05:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109865

  3. Garvin Hicking commented on patch set 2 V -1 10/02/26, 07:32

    Published edit on patch set 1.
  4. Garvin Hicking marked it ready for review 10/02/26, 07:32

  5. core-ci voted on patch set 2 V +1 10/02/26, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109883

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 10/02/26, 08:57

  7. Garvin Hicking merged patch set 3 10/02/26, 08:57