Review main Ready for review Quiet

96309[BUGFIX] Render workspaces module for a missing page

Georg Tiefenbrunn CR 0 V 0 Normal +83 −1 updated 10/02/26, 11:52

Commit message

The workspaces module passes the result of BackendUtility::getRecord()
to DocHeaderComponent::setPageBreadcrumb(), which expects an array.
For a deleted or missing page, getRecord() returns null,
and the module fails with a TypeError.

This happens for example after the selected page has been deleted
in a workspace.
The module state keeps its id,
and the next switch to the workspaces module opens it with that id.

An empty page record is now used in this case, as for the root page.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/96309/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/96309/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 3

Issues 2

Files 2

Review log 12

  1. Georg Tiefenbrunn uploaded patch set 1 10/02/26, 11:37

  2. core-ci voted on patch set 1 V +1 10/02/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109925