Review 14.3 Merged

96317[BUGFIX] Persist task parameters in SchedulerTaskRepository::add()

Simon Schaufelberger CR +2 V +2 Normal +166 −5 updated 10/08/26, 17:25

Commit message

SchedulerTaskRepository::add() did not persist task parameters:

- For native tasks, individual parameter fields were never passed to
  DataHandler.
- For non-native tasks, the DataHandler hook recreated the task object
  but did not restore its parameters, so they were overwritten by
  defaults.

Include native task parameters in the data map and restore parameters
when the persistence validator rebuilds the task object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Simon Schaufelberger uploaded patch set 1 10/02/26, 14:44

  2. Benni Mack commented on patch set 1 10/02/26, 14:52

    SchedulerTaskRepository.php:76

    how about `$fields = array_merge($task->getTaskParameters(), $fields);`?
  3. core-ci voted on patch set 1 V +1 10/02/26, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109950

  4. Simon Schaufelberger commented on patch set 1 10/02/26, 15:02

    SchedulerTaskRepository.php:76 Reply

    fine for me but what would be better then?
  5. Simon Schaufelberger uploaded patch set 2 V +1 10/02/26, 15:04

  6. core-ci voted on patch set 2 V +1 10/02/26, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109956

  7. Benni Mack commented on patch set 2 10/02/26, 15:31

    SchedulerTaskRepository.php:76 Reply

    if somebody would modify a field in the task parameters like $'tstamp' it would override $fields['tstamp']
  8. Simon Schaufelberger commented on patch set 2 10/02/26, 15:42

    SchedulerTaskRepository.php:76 Reply

    Acknowledged
  9. Benni Mack commented on patch set 3 V +1 10/07/26, 15:09

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/scheduler/Classes/Hooks/SchedulerTaskPersistenceValidator.php * typo3/sysext/scheduler/Tests/Functional/Domain/Repository/SchedulerTaskRepositoryTest.php
  10. Benni Mack commented on patch set 4 10/07/26, 15:10

    Published edit on patch set 3.
  11. Benni Mack marked it ready for review 10/07/26, 15:10

  12. core-ci voted on patch set 3 V -1 10/07/26, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110346

  13. core-ci voted on patch set 4 V -1 10/07/26, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110347

  14. Simon Schaufelberger uploaded patch set 5 V -1 10/07/26, 23:59

  15. core-ci voted on patch set 5 V +1 10/08/26, 00:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110422

  16. Benni Mack voted on patch set 5 CR +2 V +2 10/08/26, 17:25

  17. Benni Mack merged patch set 6 10/08/26, 17:25