96377[BUGFIX] Auto-create inline foreign_sortby column
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/96377/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/96377/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Markus Klein +1
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Markus Klein +1
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 4
Issues 1
Files 2
Review log 1012
-
Georg Ringer uploaded patch set 1 10/05/26, 21:03
-
Georg Ringer commented on patch set 1 CR +1 V +1 10/05/26, 21:04
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/05/26, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110156
-
Simon Schaufelberger commented on patch set 1 10/05/26, 23:56
DefaultTcaSchema.php:900why false? foreign keys should not be negative numbers imo -
Mathias Brodala commented on patch set 1 10/06/26, 07:09
DefaultTcaSchemaTest.php:2660Just from reading this test does not really verify the "skip column if defined on the foreign table already". The result will be the same if you drop either the local side or the foreign side from the test. AFAIS the actual test should be verifying that no "ColumnAlreadyExists" exception is thrown. -
Georg Ringer uploaded patch set 2
CR +1V +111/03/26, 19:42 -
Georg Ringer commented on patch set 2 11/03/26, 19:43
DefaultTcaSchema.php:900ReplyThis is a sorting value, not a foreign key. It matches the auto-created ctrl.sortby column, which is signed as well. The ID columns (foreign_field) above are unsignedDefaultTcaSchemaTest.php:2660Replythe test now predefines bSorting as BIGINT on the child table and asserts it is left untouched. Without the isColumnDefinedForTable() check it fails with ColumnAlreadyExists. -
Georg Ringer commented on patch set 2 11/03/26, 19:43
DefaultTcaSchema.php:900ReplyDoneDefaultTcaSchemaTest.php:2660ReplyDone -
core-ci voted on patch set 2 V +1 11/03/26, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113213
-
Markus Klein commented on patch set 2 11/03/26, 20:03
DefaultTcaSchema.php:900ReplySince I was about to write the same comment: I think this is a mistake, also for the sortby. -
Markus Klein voted on patch set 2 CR +1 V +1 11/03/26, 20:04
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 00:59