Review 13.4 Merged

96397[TASK] Speed up styleguide demo data generation

Benjamin Franzke CR +2 V +2 Normal +78 −9 updated 10/06/26, 09:56

Commit message

Generating the TCA demo data hashed the same password once per
password field. Argon2 is slow by design, so hashing made up most of
the runtime. Hash each plain text password only once and reuse a
single hash for both demo backend users.

Additionally, all caches were flushed before every DataHandler run
on CLI, which the frontend generator executes five times. They are
now flushed once after all records have been written.

Measured runtime of the generator commands on a local SQLite instance:

* `styleguide:generate -c tca`: -9s
  (16 password hashes less, which require ~0.5s each)
* `styleguide:generate -c frontend`: -0.1s
  (4 cache flushes less)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Benjamin Franzke commented on patch set 1 10/06/26, 06:33

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 10/06/26, 06:33

  3. Benjamin Franzke uploaded patch set 2 10/06/26, 07:25

  4. core-ci voted on patch set 1 V -1 10/06/26, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110186

  5. core-ci voted on patch set 2 V +1 10/06/26, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110195

  6. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/06/26, 09:56

    This change is ready for review.
  7. Benjamin Franzke merged patch set 3 10/06/26, 09:56