Review main Merged

96399[TASK] Remove unnecessary ksort() in BackendLayoutWizardElement

Oli Bartsch CR +2 V +2 Easy +0 −3 updated 10/06/26, 08:08

Commit message

The spanned matrix row is sorted after it has been fully processed,
but it is never iterated again; lookups happen by key only. The
guarding "!== []" check is also always true, since rows are only
created by writing a value into them, which PHPStan 2.3 reports.

Remove the dead block.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Sebastian Iffland +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 10/06/26, 07:03

  2. core-ci voted on patch set 1 V +1 10/06/26, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110188

  3. Sebastian Iffland voted on patch set 1 CR +1 10/06/26, 07:40

  4. Wouter Wolters voted on patch set 1 CR +1 10/06/26, 07:49

  5. Josua Vogel voted on patch set 1 CR +1 V +1 10/06/26, 07:49

  6. Benni Mack voted on patch set 1 CR +1 V +1 10/06/26, 08:03

  7. Oli Bartsch voted on patch set 1 CR +2 V +2 10/06/26, 08:08

  8. Oli Bartsch merged patch set 2 10/06/26, 08:08