Issue Task Resolved

#110922Remove unnecessary ksort() in BackendLayoutWizardElement

Oliver Bartsch 10/06/26, 07:03 updated 10/06/26, 11:15

Description

PHPStan 2.3 reports the “!== []” guard around ksort($spannedMatrix[$i]) as always true. The sort itself is dead code: the row is never iterated again, lookups happen by key only. Remove the block (and the related baseline entry in 13.4).

Reviews 3

History 25

  1. Oliver Bartsch commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-10-06T08:10:10+00:00" > 10/06/26, 08:10 </span>

    Applied in changeset commit:fde62d36d6ab8b92ac31367eda79f262df7fd543.

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 96404 status Resolved Under Review <span data-processor="relativetime" data-value="2026-10-06T08:13:52+00:00" > 10/06/26, 08:13 </span>

  3. Oliver Bartsch commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-10-06T11:15:12+00:00" > 10/06/26, 11:15 </span>

    Applied in changeset commit:b59ccbc431a29154df3b8405ed49bed58844d368.