Review 14.3 Merged

96400[TASK] Cover forceAbsoluteUrls for f:asset ViewHelpers

Benni Mack CR +2 V +2 Easy +23 −0 updated 10/06/26, 07:19

Commit message

Assets registered via the AssetCollector (f:asset.css and
f:asset.script) now respect config.forceAbsoluteUrls, as the
AssetRenderer generates URIs with the System Resource API, which
evaluates the frontend URL prefix of the current request.

A previous fix for this issue was reverted, as it rendered file
system paths in the frontend and no tests existed to detect it.

AbsoluteUriPrefixRenderingTest now covers assets referenced by
extension paths and by relative public paths, with and without
config.forceAbsoluteUrls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 10/06/26, 07:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/06/26, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110189

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/06/26, 07:19

  4. Benni Mack merged patch set 2 10/06/26, 07:19