Review 14.3 Merged

96408[TASK] Speed up e2e setup by respecting initCommands in typo3 setup

Benjamin Franzke CR +2 V +2 Easy +13 −9 updated 10/06/26, 11:08

Commit message

`typo3 setup` replaced the default database connection configuration
with the values written to settings.php, which drops additions from
additional.php like initCommands. SetupDatabaseService now returns
the connection settings it wrote, and the setup command merges them
into the known connection configuration instead.

The e2e setup scripts only added their SQLite initCommands once a
driver was configured, which is not the case while `typo3 setup`
boots. They now also apply when TYPO3_DB_DRIVER requests SQLite.

Measured runtime of `typo3 setup` for the e2e instance:

* -15s, as creating the schema no longer syncs every single
  statement to disk (`PRAGMA synchronous = NORMAL`)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Benjamin Franzke commented on patch set 1 10/06/26, 10:01

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Scripts/setupAcceptanceClassic.sh * typo3/sysext/install/Classes/Command/SetupCommand.php
  2. Benjamin Franzke uploaded patch set 2 10/06/26, 10:08

  3. core-ci voted on patch set 1 V -1 10/06/26, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110214

  4. core-ci voted on patch set 2 V +1 10/06/26, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110215

  5. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/06/26, 11:07

    This change is ready for review.
  6. Benjamin Franzke merged patch set 3 10/06/26, 11:08