Review 14.3 Merged

96472[BUGFIX] Respect recycle time and errors in recycler garbage collection

Oli Bartsch CR +2 V +2 Normal +87 −19 updated 10/07/26, 15:49

Commit message

Moving a file into a recycler folder keeps its modification time, so
the garbage collection task removed a file deleted today on its next
run if the file had not changed for the configured number of days.
The time of recycling is now derived from the change time a move
sets on the moved file or folder. Where a driver reports no such
time, the modification time is used as before.

A file or folder that could not be removed, e.g. due to the denied
file extension of a PHP file, aborted the whole run and left the
remaining recycler folders untouched. Such errors are now logged and
the cleanup continues, while the task still reports a failed run.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 10/07/26, 13:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/07/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110325

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/07/26, 15:49

  4. Oli Bartsch merged patch set 2 10/07/26, 15:49