Review 14.3 Merged

96492[DOCS] Clarify arguments of ExpressionBuilder::inSet()

Benni Mack CR +2 V +2 Easy +24 −9 updated 10/07/26, 17:39

Commit message

The docblocks of inSet() and notInSet() did not tell which argument
is the comma-separated list and which is the value searched for. As
the order is the reverse of MySQL's FIND_IN_SET(needle, haystack),
the methods were easily confused with in().

The docblocks now name the field as haystack and the value as
needle, give an example, state that the value is not quoted
automatically and point to in() for the opposite use case.

The SQLite placeholder exception of notInSet() now names the right
method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 10/07/26, 16:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/07/26, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110377

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/07/26, 17:39

  4. Benni Mack merged patch set 2 10/07/26, 17:39