Review main Ready for review

96499[BUGFIX] Make root page of XML sitemap configurable

Georg Ringer CR -1 V 0 Normal +58 −0 updated 11/12/26, 21:01

Commit message

The documentation names the constant
plugin.tx_seo.settings.xmlSitemap.sitemaps.pages.rootPage, but the
TypoScript never passed it on to the sitemap configuration, so it had
no effect.

Wire rootPage into the pages sitemap the same way as the other options,
and add the constant and the site setting seo.sitemap.pages.rootPage.
The default 0 keeps using the root page of the site.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/96499/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/96499/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Benni Mack -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 5

Review log 69

  1. Georg Ringer uploaded patch set 1 10/07/26, 18:29

  2. Georg Ringer commented on patch set 1 10/07/26, 18:30

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 10/07/26, 18:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110384

  4. Benni Mack commented on patch set 1 CR -1 10/07/26, 18:56

    please add a Important.rst
  5. Georg Ringer uploaded patch set 2 CR -1 V -1 10/10/26, 09:00

  6. core-ci voted on patch set 2 V -1 10/10/26, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110776

  7. Georg Ringer rebased onto patch set 3 V -1 11/10/26, 18:18

  8. core-ci voted on patch set 3 V +1 11/10/26, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113931

  9. Benni Mack commented on patch set 3 CR -1 11/12/26, 21:01

    Unresolved

    have to recheck this