Review 14.3 Merged

96532[BUGFIX] Skip move pointers without live record in versionOL

Benni Mack CR +2 V +2 Normal +58 −0 updated 10/08/26, 12:54

Commit message

PageRepository::versionOL() re-reads the live record of a move pointer.
If that record has been deleted, the query returns false,
which is passed on to getWorkspaceVersionOfRecord() and fails
with a TypeError, since its $liveRecord argument is typed as array.

Such move pointers are left over in installations upgraded
from older TYPO3 versions.
The row now stays false, which tells the caller to treat the record
as not accessible, as documented for $row.
A warning names the move pointer, the missing live record
and the workspace, so the orphaned row can be found and removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 10/08/26, 12:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/08/26, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110487

  3. Benni Mack commented on patch set 2 V -1 10/08/26, 12:45

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/08/26, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110492

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/08/26, 12:54

  6. Benni Mack merged patch set 3 10/08/26, 12:54