Review 14.3 Merged

96563[BUGFIX] Propagate CSV download response in QuerySearchController

Garvin Hicking CR +2 V +2 Normal +46 −7 updated 10/09/26, 16:46

Commit message

The CSV export of the database query module sent raw header()
calls, echoed the file content and terminated the request with
die, bypassing the PSR-15 middleware stack.

The download is now built as a PSR-7 response and handed back via
PropagateResponseException, like other backend download
controllers do.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Garvin Hicking commented on patch set 1 10/09/26, 14:53

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php * typo3/sysext/lowlevel/Tests/Functional/Controller/QuerySearchControllerTest.php
  2. core-ci voted on patch set 1 V -1 10/09/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110615

  3. Garvin Hicking commented on patch set 2 V -1 10/09/26, 15:00

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 10/09/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110616

  5. Benni Mack commented on patch set 3 V -1 10/09/26, 15:28

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 10/09/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110619

  7. Benni Mack commented on patch set 4 V -1 10/09/26, 16:07

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V -1 10/09/26, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110622

  9. Benni Mack commented on patch set 5 V -1 10/09/26, 16:26

    Published edit on patch set 4.
  10. core-ci voted on patch set 5 V +1 10/09/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110631

  11. Garvin Hicking marked it ready for review 10/09/26, 16:45

  12. Garvin Hicking voted on patch set 5 CR +2 V +2 10/09/26, 16:46

  13. Garvin Hicking merged patch set 6 10/09/26, 16:46