Review 14.3 Merged

96566[BUGFIX] Reset LanguageMenuProcessor state per call

Benni Mack CR +2 V +2 Normal +117 −5 updated 10/09/26, 19:19

Commit message

LanguageMenuProcessor merged the processor configuration into the
menu configuration of the previous call and appended the
canonicalization parameters to the already existing exclude list.

HrefLangGenerator is a shared event listener holding a single
LanguageMenuProcessor instance. In long-running worker processes
every request added another "id" to "addQueryString.exclude" until
parse_str() hit max_input_vars. Settings of a previous call, like
"addQueryString", leaked into subsequent calls as well.

The menu configuration now starts from its declared defaults on
every call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Benni Mack commented on patch set 1 10/09/26, 16:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/09/26, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110630

  3. Benni Mack commented on patch set 2 V -1 10/09/26, 16:48

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 10/09/26, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110655

  5. Benni Mack uploaded patch set 3 V -1 10/09/26, 19:05

  6. core-ci voted on patch set 3 V +1 10/09/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110693

  7. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 19:19

  8. Benni Mack merged patch set 4 10/09/26, 19:19