Review 14.3 Merged

96571[TASK] Enable strictFunctionTypes for the TypeScript build

Benjamin Kott CR +2 V +2 Expert +722 −591 updated 10/09/26, 19:10

Commit message

Without strictFunctionTypes a callback may declare narrower parameter
types than its caller passes, so such mismatches go unnoticed.

Most errors the option reports are fixed where the value is produced:
querySelectorAll() is called with a type argument and custom events are
registered in HTMLElementEventMap and DocumentEventMap. The annotations
this makes redundant in the callbacks are dropped.

Three install tool response types were wrong and now declare numbers,
which need an explicit string conversion. Apart from that the build
output is unchanged.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 173

Show 153 more files

Review log 57

  1. Benjamin Kott commented on patch set 1 10/09/26, 18:43

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/file-paste-handler.ts * Build/Sources/TypeScript/backend/form-engine.ts * Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts
  2. Benjamin Kott uploaded patch set 2 10/09/26, 18:50

  3. Benjamin Kott commented on patch set 2 10/09/26, 18:51

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 10/09/26, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110686

  5. core-ci voted on patch set 2 V +1 10/09/26, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110691

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 10/09/26, 19:10

  7. Benjamin Kott merged patch set 3 10/09/26, 19:10