Review 14.3 Merged

96574[BUGFIX] Keep live uids of non-child relations in workspaces

Benni Mack CR +2 V +2 Hard +432 −12 updated 10/09/26, 19:46

Commit message

When a record is auto-versionized in a workspace,
getVersionizedIncomingFieldArray() rewrote every incoming
relation value that has a foreign_table to the uid of the
auto-created version. That is correct for children owned by
the record, which are versionized along with it, but wrong
for "select", "group" and "category" relations pointing to
independent records: If such a record happens to be edited
in the same request, it gets a version of its own, and the
relation is bent to that version uid. Publishing then leaves
the live record pointing to a uid that no longer exists, so
the relation is silently lost.

The rewrite is now limited to "inline" and "file" relations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 17

Review log 46

  1. Benni Mack commented on patch set 1 10/09/26, 19:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/09/26, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110696

  3. Benni Mack uploaded patch set 2 V -1 10/09/26, 19:32

  4. core-ci voted on patch set 2 V +1 10/09/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110703

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 19:46

  6. Benni Mack merged patch set 3 10/09/26, 19:46