Review 14.3 Merged

96577[BUGFIX] Unwrap Extbase request for error page

Georg Ringer CR +2 V +2 Easy +46 −1 updated 10/10/26, 06:27

Commit message

An Extbase action that answers with a 404 page passes its own
$this->request to ErrorController::pageNotFoundAction().
PageContentErrorHandler creates the sub-request for the error page
from this request, so the sub-request is still an Extbase request
with the "extbase" attribute of the plugin. The error page is then
rendered in the context of the plugin, and FLUIDTEMPLATE uses the
template of the plugin instead of the page template.

The "extbase" attribute is now removed from the sub-request. For an
Extbase request, this also returns the plain request it wraps.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Georg Ringer commented on patch set 1 10/09/26, 19:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/09/26, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110702

  3. Georg Ringer uploaded patch set 2 V -1 10/10/26, 05:10

  4. core-ci voted on patch set 2 V +1 10/10/26, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110751

  5. Georg Ringer voted on patch set 2 CR +2 V +2 10/10/26, 06:27

  6. Georg Ringer merged patch set 3 10/10/26, 06:27