Review main Ready for review Quiet

96586[BUGFIX] Encode substituted values in Redirect finisher parameters

Wolfgang Klinger CR 0 V 0 Normal +97 −3 updated 10/23/26, 11:57

Commit message

The Redirect finisher replaced "{field}" placeholders in its
"additionalParameters" option with the raw submitted values and
passed the result to typolink as a query string. A value with
"+", "&", "%" or "#" changed the meaning of that string, so an
email like "test+tag@example.com" arrived as "test tag@example.com".

The finisher now translates and parses the option template first,
substitutes the values per parameter and builds a properly encoded
query string. Multiple values are still joined with ", ".

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/96586/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/96586/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 2

Review log 46

  1. Wolfgang Klinger uploaded patch set 1 10/10/26, 05:20

  2. core-ci voted on patch set 1 V +1 10/10/26, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110752

  3. Josua Vogel commented on patch set 1 10/23/26, 11:10

    RedirectFinisher.php:64

    please use parseOption() like before

    RedirectFinisher.php:69 Unresolved

    This changes the output for placeholders that resolve to an array. With "ids={multiCheckbox}" the redirect used to carry "ids=1, 2 (AbstractFinisher::arrayToString() joins with ", ", not ","), now it carries "ids[0]=1&ids[1]=2". A plugin on the target page that reads "ids" as a string receives an array afterwards. I would say we need an Important.rst entry
  4. Wolfgang Klinger uploaded patch set 2 V +1 10/23/26, 11:43

  5. Wolfgang Klinger commented on patch set 2 10/23/26, 11:44

    RedirectFinisher.php:64 Reply

    parseOption() substitutes the values into the string before it is parsed, which is the bug itself, so it can't be used as is.
  6. core-ci voted on patch set 2 V +1 10/23/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112285