96586[BUGFIX] Encode substituted values in Redirect finisher parameters
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/96586/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/96586/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 2
Review log 46
-
Wolfgang Klinger uploaded patch set 1 10/10/26, 05:20
-
core-ci voted on patch set 1 V +1 10/10/26, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110752
-
Josua Vogel commented on patch set 1 10/23/26, 11:10
RedirectFinisher.php:69UnresolvedThis changes the output for placeholders that resolve to an array. With "ids={multiCheckbox}" the redirect used to carry "ids=1, 2 (AbstractFinisher::arrayToString() joins with ", ", not ","), now it carries "ids[0]=1&ids[1]=2". A plugin on the target page that reads "ids" as a string receives an array afterwards. I would say we need an Important.rst entry -
Wolfgang Klinger uploaded patch set 2
V +110/23/26, 11:43 -
Wolfgang Klinger commented on patch set 2 10/23/26, 11:44
RedirectFinisher.php:64ReplyparseOption() substitutes the values into the string before it is parsed, which is the bug itself, so it can't be used as is. -
core-ci voted on patch set 2 V +1 10/23/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112285
RedirectFinisher.php:64