Review 14.3 Merged

96593[TASK] Remove redundant IN value null check

Benni Mack CR +2 V +2 Easy +14 −13 updated 10/10/26, 10:34

Commit message

DataMapper::getPlainValue() cannot return null, and parameter creation
already calls it. Build each parameter once and check the resulting
list for emptiness. Cover the empty-list exception.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack commented on patch set 1 10/10/26, 10:12

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php
  2. Benni Mack commented on patch set 2 10/10/26, 10:12

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 10/10/26, 10:13

    Published edit on patch set 2.
  4. Benni Mack marked it ready for review 10/10/26, 10:13

  5. core-ci voted on patch set 1 V -1 10/10/26, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110788

  6. core-ci voted on patch set 2 V -1 10/10/26, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110789

  7. core-ci voted on patch set 3 V +1 10/10/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110790

  8. Benni Mack voted on patch set 3 CR +2 V +2 10/10/26, 10:34

  9. Benni Mack merged patch set 4 10/10/26, 10:34