Review main Merged

96607[TASK] Restore global state in unit tests

Wouter Wolters CR +2 V +2 Easy +8 −18 updated 10/12/26, 18:18

Commit message

Enable global backup for tests that change the execution time or
installation encryption key. Remove teardown methods that unset the key
instead of restoring its previous value.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Wouter Wolters uploaded patch set 1 10/11/26, 11:41

  2. core-ci voted on patch set 1 V +1 10/11/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110849

  3. Georg Ringer voted on patch set 1 CR +1 V +1 10/11/26, 12:37

  4. Oliver Klee voted on patch set 1 CR +1 V +1 10/11/26, 14:24

  5. Wouter Wolters uploaded patch set 2 CR +1 V +1 10/12/26, 17:23

  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/12/26, 17:28

  7. core-ci voted on patch set 2 V +1 10/12/26, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110913

  8. Georg Ringer voted on patch set 2 CR +2 V +2 10/12/26, 18:18

  9. Georg Ringer merged patch set 3 10/12/26, 18:18