#111015Unit tests do not restore global state
Description
Several unit tests leave global state changed after execution:
- CacheTimeoutTest changes EXEC_TIME without restoring it.
- AuthenticationServiceTest, NonceTest, and UserSessionTest unset the encryption key instead of restoring its previous value.
This can make subsequent tests depend on execution order.
Reviews 1
History 13
-
Gerrit Code Review pushed patch set 1 for main to change 96607 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-11T11:41:38+00:00" > 10/11/26, 11:41 </span> -
Gerrit Code Review pushed patch set 2 for main to change 96607 <span data-processor="relativetime" data-value="2026-10-12T17:23:57+00:00" > 10/12/26, 17:23 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-12T18:25:10+00:00" > 10/12/26, 18:25 </span>
Applied in changeset commit:f808273bf5bd4856569f5a1ec26429df2292da4b.