96627[BUGFIX] Reject invalid form page index gracefully
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php5+9 −1
- typo3/sysext/core/Tests/Unit/Error/AbstractExceptionHandlerTest.phpnew+49 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+8 −1
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+30 −0
- typo3/sysext/frontend/Classes/ContentObject/Exception/ProductionExceptionHandler.php+6 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Exception/ProductionExceptionHandlerTest.php+32 −0
Review log 1417
-
Nikita Hovratov uploaded patch set 1 10/12/26, 08:12
-
core-ci voted on patch set 1 V +1 10/12/26, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110891
-
Josua Vogel commented on patch set 1 10/12/26, 08:30
-
Nikita Hovratov uploaded patch set 2
V +110/12/26, 08:58 -
Nikita Hovratov commented on patch set 2 10/12/26, 08:59
AbstractExceptionHandler.php:60ReplyDone -
core-ci voted on patch set 2 V +1 10/12/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110896
-
Wouter Wolters voted on patch set 2 CR +1 V +1 10/12/26, 19:26
-
Josua Vogel commented on patch set 2 10/12/26, 19:51
AbstractExceptionHandler.php:57I just noticed that the new exception is listed under IGNORED_HMAC_EXCEPTION_CODES. That's technically incorrect. I'm not sure if we should ignore it. This list prevents logging, which is what we want in this case. We can't rename the list itself because the class isn't internal. -
Nikita Hovratov commented on patch set 2 11/10/26, 11:38
AbstractExceptionHandler.php:57ReplyWhat would you suggest? Add a new list just for the one exception? Or add a comment for the constant, to explain this list is used to skip logging? Or maybe even make a complete new list? -
Josua Vogel uploaded patch set 3
CR +1V +111/10/26, 14:39 -
Josua Vogel commented on patch set 3 11/10/26, 14:40
Addressed the logging classification finding by separating invalid-request exception codes from HMAC codes while retaining suppression in both handlers. Added core, frontend and form regression coverage. Unit tests, form functional tests, PHP integrity checks and CGL pass. -
Josua Vogel commented on patch set 3 11/10/26, 14:41
AbstractExceptionHandler.php:57ReplyYes, a new list. I already pushed the change 😊 -
core-ci voted on patch set 3 V +1 11/10/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113911
-
Josua Vogel voted on patch set 3 CR +1 V +1 11/10/26, 15:00
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/10/26, 18:08
-
Benni Mack voted on patch set 3 CR +2 V +2 11/11/26, 17:04
-
Benni Mack merged patch set 4 11/11/26, 17:04
AbstractExceptionHandler.php:60