#111026EXT:form There is no page with an index of -1 (FormDefinition)
Description
There is no real sanitation / exception handling for invalid currentIndex values in FormDefinition.
Right now the value is always casted to int. Instead, it should be checked if the value is even an integer. If not, then this is a user error and should be handled gracefully by rendering an exception message in the frontend. Otherwise the log will be flooded by invalid requests from malicious bots like this one:
tx_form_formframework
{
__trustedProperties: {"newsletterSubscription-18053":{"email":1,"__currentPage":1}}96fc2b1125fe37df4b10de8324b91998895ac300db97601423b83aaac6e0293e,
newsletterSubscription-18053: {
__currentPage: -1 OR 5*5=25 -- ,
__session: 015dced8f1600ef99a63a3a009599fb32f6a0263|15183269ef52b60046d47063c390a05981e7ac8f06e2da5b389e52719e6daf3b,
__state: TzozOToiVFlQTzNcQ01TXEZvcm1cRG9tYWluXFJ1bnRpbWVcRm9ybVN0YXRlIjoyOntzOjI1OiIAKgBsYXN0RGlzcGxheWVkUGFnZUluZGV4IjtpOjA7czoxMzoiACoAZm9ybVZhbHVlcyI7YTozOntzOjEyOiJzdGF0aWN0ZXh0LTEiO047czo1OiJlbWFpbCI7czoxOToidGVzdGluZ0BleGFtcGxlLmNvbSI7czoxMjoic3RhdGljdGV4dC0zIjtOO319999a025c2865cb2b90876ca37e0ad2b9a6fffc53fa0a1ac960b5fe6a2e51db87,
email: testing@example.com
}
}Reviews 2
History 27
-
Gerrit Code Review pushed patch set 1 for main to change 96627 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-12T08:12:48+00:00" > 10/12/26, 08:12 </span> -
Gerrit Code Review pushed patch set 2 for main to change 96627 <span data-processor="relativetime" data-value="2026-10-12T08:58:42+00:00" > 10/12/26, 08:58 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 96627 <span data-processor="relativetime" data-value="2026-11-10T14:39:45+00:00" > 11/10/26, 14:39 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97559 <span data-processor="relativetime" data-value="2026-11-11T17:04:45+00:00" > 11/11/26, 17:04 </span>
-
Nikita Hovratov commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-11T17:10:16+00:00" > 11/11/26, 17:10 </span> -
Gerrit Code Review pushed patch set 2 for 14.3 to change 97559 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2026-11-11T20:04:52+00:00" > 11/11/26, 20:04 </span> -
Nikita Hovratov commented and changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2026-11-11T21:20:13+00:00" > 11/11/26, 21:20 </span>Applied in changeset commit:3c943e75b66339af9101a8b94db1194b89c2b8cd.
Applied in changeset commit:17a94132b114b798875e816c32fc491c81ebc5dc.