Issue Bug Resolved

#111026EXT:form There is no page with an index of -1 (FormDefinition)

Nikita Hovratov 10/12/26, 07:29 updated 11/11/26, 21:20

Description

There is no real sanitation / exception handling for invalid currentIndex values in FormDefinition.
Right now the value is always casted to int. Instead, it should be checked if the value is even an integer. If not, then this is a user error and should be handled gracefully by rendering an exception message in the frontend. Otherwise the log will be flooded by invalid requests from malicious bots like this one:

tx_form_formframework
{
__trustedProperties: {"newsletterSubscription-18053":{"email":1,"__currentPage":1}}96fc2b1125fe37df4b10de8324b91998895ac300db97601423b83aaac6e0293e,
newsletterSubscription-18053: {
__currentPage: -1 OR 5*5=25 -- ,
__session: 015dced8f1600ef99a63a3a009599fb32f6a0263|15183269ef52b60046d47063c390a05981e7ac8f06e2da5b389e52719e6daf3b,
__state: TzozOToiVFlQTzNcQ01TXEZvcm1cRG9tYWluXFJ1bnRpbWVcRm9ybVN0YXRlIjoyOntzOjI1OiIAKgBsYXN0RGlzcGxheWVkUGFnZUluZGV4IjtpOjA7czoxMzoiACoAZm9ybVZhbHVlcyI7YTozOntzOjEyOiJzdGF0aWN0ZXh0LTEiO047czo1OiJlbWFpbCI7czoxOToidGVzdGluZ0BleGFtcGxlLmNvbSI7czoxMjoic3RhdGljdGV4dC0zIjtOO319999a025c2865cb2b90876ca37e0ad2b9a6fffc53fa0a1ac960b5fe6a2e51db87,
email: testing@example.com
}
}

Reviews 2

History 27

  1. Nikita Hovratov commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-11-11T17:10:16+00:00" > 11/11/26, 17:10 </span>

    Applied in changeset commit:17a94132b114b798875e816c32fc491c81ebc5dc.

  2. Gerrit Code Review pushed patch set 2 for 14.3 to change 97559 status Resolved Under Review <span data-processor="relativetime" data-value="2026-11-11T20:04:52+00:00" > 11/11/26, 20:04 </span>

  3. Nikita Hovratov commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-11-11T21:20:13+00:00" > 11/11/26, 21:20 </span>

    Applied in changeset commit:3c943e75b66339af9101a8b94db1194b89c2b8cd.