Review 14.3 Merged

96643[BUGFIX] Create responses with a text body correctly

Georg Ringer CR +2 V +2 Normal +58 −3 updated 10/12/26, 20:31

Commit message

The constructor of TYPO3\CMS\Core\Http\Response treats a string body as
a stream identifier and opens it with fopen(). Passing the response
text there failed:

The StaticRouteResolver emitted a PHP warning for invalid route
arguments and sent an empty 404 response instead of "Invalid route".
The live search crashed with a ValueError for an empty query instead of
answering with 400.

Both now pass the text in a way that writes it as the response body.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Georg Ringer commented on patch set 1 10/12/26, 19:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/12/26, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110938

  3. Georg Ringer uploaded patch set 2 V -1 10/12/26, 20:13

  4. core-ci voted on patch set 2 V +1 10/12/26, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110949

  5. Georg Ringer voted on patch set 2 CR +2 V +2 10/12/26, 20:31

  6. Georg Ringer merged patch set 3 10/12/26, 20:31