Review 14.3 Merged

96673[BUGFIX] Remember last used action of indexing module

Oli Bartsch CR +2 V +2 Normal +172 −25 updated 10/14/26, 11:52

Commit message

Selecting a page in the page tree, or opening the module via the
module menu, always showed the first action of the "Indexing"
module instead of the one selected before.

The controller tried to restore the last used action from the user
settings. Since Extbase backend modules use explicit routes, the
default route always provides an action, so this code was never
reached. It furthermore stored all request arguments, including
record specific ones.

The module now declares the menu action as module data, stores it
when one of the module menu actions is requested explicitly and
restores it when the module is called via its default route.
Detail views are not remembered.

The page tree keeps linking to the module entry point, leaving it
to the module to decide which state is relevant.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 58

  1. Oli Bartsch commented on patch set 1 10/14/26, 07:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/14/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111047

  3. Oli Bartsch uploaded patch set 2 V -1 10/14/26, 07:40

  4. core-ci voted on patch set 2 V -1 10/14/26, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111050

  5. Oli Bartsch uploaded patch set 3 V -1 10/14/26, 08:29

  6. core-ci voted on patch set 3 V +1 10/14/26, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111058

  7. Oli Bartsch voted on patch set 3 CR +2 V +2 10/14/26, 11:51

  8. Oli Bartsch merged patch set 4 10/14/26, 11:52