Review main Merged

96698[BUGFIX] Skip translation source field in diffsource of translations

Alexander Schnitzler CR +2 V +2 Normal +109 −1 updated 10/15/26, 17:10

Commit message

Since #106827, the language related fields of the default language
record are left out of the diffsource of a translation. The
translation source field, e.g. "l10n_source", is still stored: the
condition meant to skip it compares the origin pointer field a second
time.

The check for the translation source field now compares against the
translation source field instead of the translation origin pointer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 10/14/26, 18:39

  2. core-ci voted on patch set 1 V -1 10/14/26, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111142

  3. Alexander Schnitzler uploaded patch set 2 V -1 10/14/26, 19:58

  4. core-ci voted on patch set 2 V +1 10/14/26, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111146

  5. Alexander Schnitzler commented on patch set 2 10/14/26, 20:14

    This change is ready for review.
  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/15/26, 13:45

  7. Benni Mack voted on patch set 2 CR +2 V +2 10/15/26, 17:09

  8. Benni Mack merged patch set 3 10/15/26, 17:10