#111071l10n_source is stored in diffsource of translations
Description
When a record is translated, DataHandler stores the values of the default language record as JSON in the field configured as transOrigDiffSourceField (e.g. l10n_diffsource). Since #106827, the language related fields are meant to be left out: the language field, the diffsource field itself, transOrigPointerField and translationSource.
translationSource (e.g. l10n_source) is still stored.
Reproduction
Localize a tt_content record to another language:
$dataHandler->start([], ['tt_content' => [1 => ['localize' => 1]]]);
$dataHandler->process_cmdmap();
Expected
The diffsource JSON of the translation contains no key l10n_source, like it contains no sys_language_uid and no l18n_parent.
Actual
The diffsource JSON contains l10n_source.
Cause
The condition in DataHandler::fillInFieldArray() meant to skip the translation source field compares the origin pointer field a second time:
// not "l10n_source", this is 0 in default language record by definition
&& !($languageCapability->hasTranslationSourceField() && $languageCapability->getTranslationOriginPointerField()->getName() === (string)$field)
Using getTranslationSourceField() there fixes it. Introduced with #106827 (main, 13.4).
Reviews 3
Related issues 1
History 28
-
Alexander Schnitzler changed Related to #106827 <span data-processor="relativetime" data-value="2026-10-14T18:15:06+00:00" > 10/14/26, 18:15 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 96698 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-14T18:39:04+00:00" > 10/14/26, 18:39 </span> -
Gerrit Code Review pushed patch set 2 for main to change 96698 <span data-processor="relativetime" data-value="2026-10-14T19:58:04+00:00" > 10/14/26, 19:58 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 96734 <span data-processor="relativetime" data-value="2026-10-15T17:10:36+00:00" > 10/15/26, 17:10 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 96735 <span data-processor="relativetime" data-value="2026-10-15T17:10:58+00:00" > 10/15/26, 17:10 </span>
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 96735 <span data-processor="relativetime" data-value="2026-10-15T17:11:24+00:00" > 10/15/26, 17:11 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 96734 <span data-processor="relativetime" data-value="2026-10-15T17:11:40+00:00" > 10/15/26, 17:11 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-15T17:15:11+00:00" > 10/15/26, 17:15 </span>
Applied in changeset commit:09bb7a9168a0db2a7575f7596538208e34b980d7.