Review 14.3 Merged

96707[BUGFIX] Return a failure exit code from fluid:analyze --json

Garvin Hicking CR +2 V +2 Normal +63 −4 updated 10/15/26, 09:33

Commit message

With --json, fluid:analyze printed the errors of invalid templates
but always returned exit code 0. Without --json, the command returns
exit code 1 if a template has errors. A CI step that used --json
could not fail on template errors.

Return exit code 1 with --json as well if a template has errors.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 10/15/26, 08:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/15/26, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111168

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 10/15/26, 09:32

  4. Garvin Hicking merged patch set 2 10/15/26, 09:33