Review 14.3 Merged

96723[TASK] Add a disabled state to generic and pseudo buttons

Benjamin Kott CR +2 V +2 Normal +162 −22 updated 10/15/26, 15:01

Commit message

GenericButton::setDisabled() renders the attribute "disabled".

The custom elements of the backend that act as a button follow that
attribute as a disabled <button> does: no activation by a click, Enter
or Space, out of the tab order, announced as disabled. The sidebar
toggle, which did this on its own, now inherits it.

Also the LinkButton is adapted to set tabindex to -1 if it is
disabled in order to ensure it is not focusable, in order to
create a uniform behavior across all button types.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 46

  1. Benjamin Kott commented on patch set 1 10/15/26, 14:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/15/26, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111202

  3. Benjamin Kott uploaded patch set 2 V -1 10/15/26, 14:42

  4. core-ci voted on patch set 2 V +1 10/15/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111211

  5. Benjamin Kott voted on patch set 2 CR +2 V +2 10/15/26, 15:01

  6. Benjamin Kott merged patch set 3 10/15/26, 15:01