Review 14.3 Merged

96724[TASK] Show the QR code button disabled without a URL

Benjamin Kott CR +2 V +2 Easy +21 −1 updated 10/15/26, 15:13

Commit message

ComponentFactory::createQrCodeButton() renders the button disabled for
an empty URL, as createViewButton() does without preview attributes.
A module can then show both buttons the same way where a page has no
frontend URL, instead of a QR code button with nothing to encode.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benjamin Kott commented on patch set 1 10/15/26, 14:14

    Cherry Picked from branch main.
  2. Benjamin Kott rebased onto patch set 2 10/15/26, 15:02

  3. core-ci voted on patch set 1 V -1 10/15/26, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111203

  4. core-ci voted on patch set 2 V +1 10/15/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111215

  5. Benjamin Kott voted on patch set 2 CR +2 V +2 10/15/26, 15:13

  6. Benjamin Kott merged patch set 3 10/15/26, 15:13