Review 13.4 Merged

96735[BUGFIX] Skip translation source field in diffsource of translations

Benni Mack CR +2 V +2 Normal +109 −1 updated 10/15/26, 22:12

Commit message

Since #106827, the language related fields of the default language
record are left out of the diffsource of a translation. The
translation source field, e.g. "l10n_source", is still stored: the
condition meant to skip it compares the origin pointer field a second
time.

The check for the translation source field now compares against the
translation source field instead of the translation origin pointer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Benni Mack commented on patch set 1 10/15/26, 17:10

    Cherry Picked from branch 14.3.
  2. Benni Mack commented on patch set 2 10/15/26, 17:11

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 10/15/26, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111251

  4. core-ci voted on patch set 2 V +1 10/15/26, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111252

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/15/26, 22:12

  6. Benni Mack merged patch set 3 10/15/26, 22:12