Review main Merged

96773[BUGFIX] Let GD sharpening grow with its strength

Benjamin Kott CR +2 V +2 Normal +90 −4 updated 10/21/26, 09:35

Commit message

GraphicsCanvas::sharpen() divided its kernel by a sum that grew with
the strength, so GIFBUILDER sharpened less the higher sharpen was set.

It now sharpens on one even scale with ImageMagick and GraphicsMagick:
each of its ten steps adds the same strength, and step n sharpens like
-unsharp 1x2+(n*0.25)+0. Step 1 is what GFX/sharpen applies to
scaled-down images.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1118

  1. Benjamin Kott uploaded patch set 1 10/17/26, 01:43

  2. core-ci voted on patch set 1 V +1 10/17/26, 01:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111412

  3. Benjamin Kott uploaded patch set 2 V +1 10/17/26, 08:43

  4. core-ci voted on patch set 2 V +1 10/17/26, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111429

  5. Benjamin Kott rebased onto patch set 3 V +1 10/17/26, 11:55

  6. core-ci voted on patch set 3 V +1 10/17/26, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111451

  7. Benjamin Kott uploaded patch set 4 V +1 10/19/26, 14:51

  8. core-ci voted on patch set 4 V +1 10/19/26, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111660

  9. Benjamin Kott commented on patch set 4 10/20/26, 09:48

    This change is ready for review.
  10. Garvin Hicking voted on patch set 4 CR +1 V +1 10/20/26, 09:59

  11. Benjamin Kott rebased onto patch set 5 CR +1 V +1 10/20/26, 19:07

  12. core-ci voted on patch set 5 V +1 10/20/26, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111924

  13. Benjamin Kott uploaded patch set 6 V +1 10/20/26, 21:10

  14. core-ci voted on patch set 6 V -1 10/20/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111939

  15. Benjamin Kott rebased onto patch set 7 V -1 10/20/26, 21:59

  16. core-ci voted on patch set 7 V +1 10/20/26, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111944

  17. Oli Bartsch voted on patch set 7 CR +2 V +2 10/21/26, 09:34

  18. Oli Bartsch merged patch set 8 10/21/26, 09:35