#111103GIFBUILDER sharpen gets weaker with a higher strength
Description
Problem
Since GIFBUILDER draws with GraphicsCanvas instead of ImageMagick, the sharpen value of an EFFECT object and of niceText.sharpen works the wrong way round: sharpen = 10 sharpens the image strongly, sharpen = 90 barely at all. With ImageMagick, GraphicalFunctions::v5_sharpen() sharpened more the higher the value, from -sharpen 1x2 to -sharpen 5x5. Even the weakest step is about three times as strong as ImageMagick’s.
Steps to reproduce
- Render a GIFBUILDER image with an IMAGE object and an EFFECT object with value = sharpen = 10.
- Render the same image with value = sharpen = 90.
- Compare both: the image with 10 is sharpened much more than the one with 90.
Cause
GraphicsCanvas::sharpen() builds a 3×3 kernel with the centre 8 + v and divides by the sum of the kernel, which is v. A higher strength raises the divisor along with the centre, so the kernel gets weaker; at the lowest strength the divisor is 1 and the kernel is a full laplacian sharpen
Reviews 2
History 18
-
Gerrit Code Review pushed patch set 1 for main to change 96773 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-17T01:43:07+00:00" > 10/17/26, 01:43 </span> -
Gerrit Code Review pushed patch set 2 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-17T08:43:37+00:00" > 10/17/26, 08:43 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-17T11:55:06+00:00" > 10/17/26, 11:55 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-19T14:51:53+00:00" > 10/19/26, 14:51 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-20T19:07:18+00:00" > 10/20/26, 19:07 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-20T21:10:54+00:00" > 10/20/26, 21:10 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 96773 <span data-processor="relativetime" data-value="2026-10-20T21:59:08+00:00" > 10/20/26, 21:59 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-21T09:40:12+00:00" > 10/21/26, 09:40 </span>
Applied in changeset commit:2d4cbb28fca75d193611bdd9027c4582b774b322.