Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96776[TASK] Read image orientation independently of ext-exif
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/96776/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/96776/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 6
-
main
96780[!!!][TASK] Rename GFX/processor_effects to GFX/sharpen
The chain has patch set 2 of 7, the changes above it need a rebase.
-
main
96778[!!!][TASK] Remove the GFX setting thumbnails
The chain has patch set 4 of 5, the changes above it need a rebase.
-
main
96777[!!!][TASK] Require the PHP extension gd
The chain has patch set 1 of 2, the changes above it need a rebase.
- main 93628[WIP][TASK] Make GD the baseline image processor
-
96776 [TASK] Read image orientation independently of ext-exif This change
- main 96772[FEATURE] Add an enum and detection for image formats
Issues 1
Files 31
- typo3/sysext/core/Classes/Imaging/GraphicsCanvas.php+21 −23
- typo3/sysext/core/Classes/Imaging/ImageOrientation.php1new+47 −0
- typo3/sysext/core/Classes/Imaging/ImageOrientationReader.phpnew+415 −0
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+5 −7
- typo3/sysext/core/Classes/Upgrades/ImageOrientationDimensionsMigration.phpnew+167 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Important-111106-ImageOrientationIsReadIndependentlyOfTheExifExtension.rstnew+54 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/Test.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/AvifOrientationTest.phpnew+90 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/ImageOrientationDimensionsBase.csvnew+17 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/ImageOrientationDimensionsMigrated.csvnew+17 −0
- typo3/sysext/core/Tests/Functional/Upgrades/ImageOrientationDimensionsMigrationTest.phpnew+73 −0
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/BottomLeft.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/BottomRight.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/LeftBottom.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/LeftTop.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/RightBottom.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/RightTop.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/TopLeft.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/Avif/TopRight.avifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/RightTop.avifnewbinary
Show 11 more files
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/RightTop.heicnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/RightTop.pngnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/RightTop.tifnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/Fixtures/Orientation/RightTop.webpnewbinary
- typo3/sysext/core/Tests/Unit/Imaging/GraphicsCanvasTest.php+65 −0
- typo3/sysext/core/Tests/Unit/Imaging/ImageOrientationReaderTest.phpnew+170 −0
- typo3/sysext/core/Tests/Unit/Type/File/Fixtures/Test-orientation6.jpgnewbinary
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+39 −0
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+4 −1
- typo3/sysext/frontend/Tests/Functional/Imaging/Fixtures/RightTop.pngnewbinary
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+28 −0
Review log 1019
-
Benjamin Kott uploaded patch set 1 10/17/26, 08:43
-
core-ci voted on patch set 1 V +1 10/17/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111430
-
Benjamin Kott rebased onto patch set 2
V +110/17/26, 11:55 -
core-ci voted on patch set 2 V +1 10/17/26, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111452
-
Benjamin Kott uploaded patch set 3
V +110/19/26, 14:51 -
core-ci voted on patch set 3 V +1 10/19/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111663
-
Benjamin Kott rebased onto patch set 4
V +110/20/26, 21:10 -
core-ci voted on patch set 4 V -1 10/20/26, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111941
-
Benjamin Kott rebased onto patch set 5
V -110/20/26, 21:59 -
core-ci voted on patch set 5 V +1 10/20/26, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111946
-
Benjamin Kott rebased onto patch set 6
V +110/21/26, 12:05 -
core-ci voted on patch set 6 V +1 10/21/26, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112003
-
Benjamin Kott uploaded patch set 7
V +110/21/26, 17:33 -
core-ci voted on patch set 7 V +1 10/21/26, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112027
-
Benjamin Kott rebased onto patch set 8
V +110/22/26, 18:42 -
core-ci voted on patch set 8 V +1 10/22/26, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112172
-
Benjamin Kott rebased onto patch set 9
V +111/09/26, 00:31 -
core-ci voted on patch set 9 V +1 11/09/26, 00:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113613
-
Simon Schaufelberger commented on patch set 9 11/09/26, 00:53
ImageOrientation.php:43Unresolved