Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

96776[TASK] Read image orientation independently of ext-exif

Benjamin Kott CR 0 V 0 Expert +1212 −31 updated 11/09/26, 00:53

Commit message

Width and height in the file metadata were those of the upright image
only where ext-exif was loaded and read the orientation, which it does
for JPEG and TIFF alone, and GIFBUILDER placed unscaled images
sideways.

ImageOrientationReader reads the EXIF orientation of JPEG, TIFF, PNG
and WebP files, through ext-exif where it is loaded and reads the
format, by itself otherwise. Of AVIF and HEIC files it reads the irot
and imir properties of the primary item, which ImageMagick applies
while decoding and the AVIF decoder of GD does not, and expresses them
as the EXIF orientation that does the same. ImageInfo and
GraphicsCanvas turn images upright by it, and an upgrade wizard
corrects the dimensions of images indexed before.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/96776/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/76/96776/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 6

  1. main 96780[!!!][TASK] Rename GFX/processor_effects to GFX/sharpen Based on this change Merged Benjamin Kott CR +2 V +2 Hard +214 −103

    The chain has patch set 2 of 7, the changes above it need a rebase.

  2. main 96778[!!!][TASK] Remove the GFX setting thumbnails Based on this change Merged Benjamin Kott CR +2 V +2 Normal +118 −63

    The chain has patch set 4 of 5, the changes above it need a rebase.

  3. main 96777[!!!][TASK] Require the PHP extension gd Based on this change Merged Benjamin Kott CR +2 V +2 Easy +46 −3

    The chain has patch set 1 of 2, the changes above it need a rebase.

  4. main 93628[WIP][TASK] Make GD the baseline image processor Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V -1 Impossible +16163 −3817
  5. 96776 [TASK] Read image orientation independently of ext-exif This change

  6. main 96772[FEATURE] Add an enum and detection for image formats This change is based on it Benjamin Kott CR 0 V 0 Expert +1087 −57

Issues 1

Files 31

Show 11 more files

Review log 1019

  1. Benjamin Kott uploaded patch set 1 10/17/26, 08:43

  2. core-ci voted on patch set 1 V +1 10/17/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111430

  3. Benjamin Kott rebased onto patch set 2 V +1 10/17/26, 11:55

  4. core-ci voted on patch set 2 V +1 10/17/26, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111452

  5. Benjamin Kott uploaded patch set 3 V +1 10/19/26, 14:51

  6. core-ci voted on patch set 3 V +1 10/19/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111663

  7. Benjamin Kott rebased onto patch set 4 V +1 10/20/26, 21:10

  8. core-ci voted on patch set 4 V -1 10/20/26, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111941

  9. Benjamin Kott rebased onto patch set 5 V -1 10/20/26, 21:59

  10. core-ci voted on patch set 5 V +1 10/20/26, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111946

  11. Benjamin Kott rebased onto patch set 6 V +1 10/21/26, 12:05

  12. core-ci voted on patch set 6 V +1 10/21/26, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112003

  13. Benjamin Kott uploaded patch set 7 V +1 10/21/26, 17:33

  14. core-ci voted on patch set 7 V +1 10/21/26, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112027

  15. Benjamin Kott rebased onto patch set 8 V +1 10/22/26, 18:42

  16. core-ci voted on patch set 8 V +1 10/22/26, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112172

  17. Benjamin Kott rebased onto patch set 9 V +1 11/09/26, 00:31

  18. core-ci voted on patch set 9 V +1 11/09/26, 00:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113613

  19. Simon Schaufelberger commented on patch set 9 11/09/26, 00:53

    ImageOrientation.php:43 Unresolved

    Maybe hasSwapedDimensions would be easier to understand?