Review 14.3 Merged

96834[BUGFIX] Limit Fluid debug output to active admin panel

Benni Mack CR +2 V +2 Normal +104 −15 updated 10/19/26, 20:47

Commit message

The admin panel's f:render override decided on its own whether to
render debug output, based solely on the stored user setting. The page
cache, however, is only disabled while the admin panel is open and the
preview module is initialized. With the panel closed but the setting
still stored, debug output was rendered into cacheable pages and then
delivered to every visitor.

The preview module now marks the request when it activates Fluid
debugging and disables the cache, and the ViewHelper only renders debug
output for requests carrying that mark.

The new request attribute "admin-panel.fluid.debug" is internal and
not considered public API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 611

  1. Benni Mack commented on patch set 1 10/18/26, 17:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/18/26, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111546

  3. Benni Mack commented on patch set 2 V -1 10/19/26, 15:51

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 10/19/26, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111669

  5. Benni Mack commented on patch set 3 V -1 10/19/26, 16:09

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 10/19/26, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111673

  7. Georg Ringer uploaded patch set 4 V -1 10/19/26, 17:43

  8. core-ci voted on patch set 4 V -1 10/19/26, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111687

  9. core-ci voted on patch set 4 V +1 10/19/26, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111687

  10. Benni Mack voted on patch set 4 CR +2 V +2 10/19/26, 20:47

  11. Benni Mack merged patch set 5 10/19/26, 20:47