Review main Ready for review

96846[BUGFIX] Copy metadata of files contained in a copied folder

Wolfgang Klinger CR 0 V 0 Normal +65 −12 updated 11/12/26, 21:26

Commit message

Copying a single file copies its metadata, copying a folder did not.
The driver copied the folder on disk only, so the contained files
were indexed lazily later on, with an empty metadata record.

ResourceStorage::copyFolder() now indexes the copied files and
copies the metadata of each source file to its copy, the same way
copyFile() does.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/96846/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/96846/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 5

Issues 1

Files 2

Review log 48

  1. Wolfgang Klinger uploaded patch set 1 10/19/26, 05:56

  2. core-ci voted on patch set 1 V +1 10/19/26, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111577

  3. Benni Mack updated the commit message in patch set 2 V +1 10/20/26, 16:14

  4. core-ci voted on patch set 2 V +1 10/20/26, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111883

  5. Benni Mack uploaded patch set 3 V +1 11/11/26, 10:05

  6. core-ci voted on patch set 3 V -1 11/11/26, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114044

  7. Benni Mack rebased onto patch set 4 V -1 11/12/26, 21:13

  8. core-ci voted on patch set 4 V +1 11/12/26, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114242