Review 13.4 Merged

96854[BUGFIX] Handle backed enum record types in f:render.text

Garvin Hicking CR +2 V +2 Easy +39 −3 updated 10/19/26, 08:17

Commit message

Extbase models can represent their TCA record type with a backed enum.
Returning this enum from getRecordType() causes a TypeError because the
method requires a nullable string.

Use the enum's backing value as a string when selecting the TCA schema.
Add a functional regression test for a CType field holding a backed enum.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 69

  1. Garvin Hicking commented on patch set 1 10/19/26, 07:56

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Render/TextViewHelper.php
  2. Garvin Hicking commented on patch set 2 10/19/26, 07:58

    Published edit on patch set 1.
  3. Garvin Hicking commented on patch set 3 10/19/26, 07:59

    Published edit on patch set 2.
  4. Garvin Hicking marked it ready for review 10/19/26, 07:59

  5. core-ci voted on patch set 3 V +1 10/19/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111599

  6. core-ci voted on patch set 1 V -1 10/19/26, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111596

  7. core-ci voted on patch set 2 V -1 10/19/26, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111598

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 10/19/26, 08:16

  9. Garvin Hicking merged patch set 4 10/19/26, 08:17