Review 14.3 Merged

96891[BUGFIX] Rewrite relative URLs in inline CSS of f:asset.css

Benni Mack CR +2 V +2 Normal +92 −0 updated 10/20/26, 10:12

Commit message

The ViewHelper `f:asset.css` with `inline="1"` embedded the stylesheet
as is, so relative `url()` and `@import` paths pointed to non-existing
locations in the HTML document. `page.includeCSS` with `inline = 1`
already rewrites them.

The ViewHelper now uses the same RelativeCssPathFixer. References to
files that do not exist now throw an exception, as with TypoScript.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Benni Mack commented on patch set 1 10/19/26, 20:55

    Cherry Picked from branch main.
  2. Benni Mack commented on patch set 2 10/19/26, 20:56

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 10/19/26, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111723

  4. core-ci voted on patch set 2 V +1 10/19/26, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111724

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 10/20/26, 10:11

  6. Garvin Hicking merged patch set 3 10/20/26, 10:12