96916[BUGFIX] Use shared language selector in recycler and record history
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 13
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+20 −18
- typo3/sysext/backend/Classes/Template/Components/Buttons/LanguageSelectorBuilder.php9+42 −1
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/ElementHistoryTranslations.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/ElementHistoryControllerTest.php+25 −0
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/LanguageSelectorBuilderTest.php+45 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-107345-RecyclerLanguageFilter.rst+3 −3
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+21 −49
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+6 −12
- typo3/sysext/recycler/Classes/Service/RecyclerService.php+1 −1
- typo3/sysext/recycler/Documentation/Editor/Index.rst+4 −3
- typo3/sysext/recycler/Tests/Functional/Controller/RecyclerModuleControllerTest.phpnew+134 −0
- typo3/sysext/recycler/Tests/Functional/Fixtures/Database/language_records.csvnew+14 −0
Review log 1924
-
Oli Bartsch uploaded patch set 1 10/20/26, 12:58
-
Oli Bartsch updated the commit message in patch set 2 10/20/26, 13:04
-
Oli Bartsch updated the commit message in patch set 3 10/20/26, 13:04
-
core-ci voted on patch set 3 V +1 10/20/26, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111819
-
Garvin Hicking commented on patch set 3 V -1 10/20/26, 14:03
Now I can no longer see "only german" records, because the english language is not unselectable -
Oli Bartsch uploaded patch set 4
V +110/20/26, 16:44 -
Oli Bartsch commented on patch set 4 10/20/26, 16:55
Reply
I've fixed this. -
core-ci voted on patch set 4 V +1 10/20/26, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111894
-
Simon Schaufelberger commented on patch set 4 10/20/26, 17:23
LanguageSelectorBuilder.php:55extract count into a variable, otherwise the calculation needs to happen 2x. micro-optimization only.LanguageSelectorBuilder.php:149same hereLanguageSelectorBuilder.php:177shouldn't we use `translate` from now on? -
Garvin Hicking commented on patch set 4 10/20/26, 18:04
Reply
(Talked about this - I believe it must be easier for a user to pick a single language without page reloads or needing to first "uncheck all" only to be able to select a single language. Especially for sites with more languages I think the recycler is usually opened to filter for a specific single language not multiple ones. Having said that, I understand the need to unify the language selector to be in line with the appearance of the other ones) -
Oli Bartsch uploaded patch set 5
V +110/20/26, 18:28 -
Oli Bartsch uploaded patch set 6 10/20/26, 18:37
-
Oli Bartsch commented on patch set 6 10/20/26, 18:42
Reply
I gave up. Let's go with your UI but using the Builder. Fine? -
Garvin Hicking commented on patch set 6 10/20/26, 18:46
Reply
Happily so. Appreciate the effort! Your agent's place, or mine? ;) -
core-ci voted on patch set 5 V +1 10/20/26, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111909
-
core-ci voted on patch set 6 V +1 10/20/26, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111913
-
Oli Bartsch uploaded patch set 7
V +110/20/26, 18:57 -
Garvin Hicking commented on patch set 7 CR +1 V +1 10/20/26, 19:01
LanguageSelectorBuilder.php:55ReplyDoneLanguageSelectorBuilder.php:149ReplyDoneLanguageSelectorBuilder.php:177ReplyDone -
Garvin Hicking commented on patch set 7 10/20/26, 19:01
Reply
Done -
Oli Bartsch commented on patch set 7 10/20/26, 19:02
Reply
We are all set. 🚀LanguageSelectorBuilder.php:55ReplyDoneLanguageSelectorBuilder.php:149ReplyDoneLanguageSelectorBuilder.php:177ReplyDone -
core-ci voted on patch set 7 V +1 10/20/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111921
-
Benni Mack voted on patch set 7 CR +1 V +1 10/22/26, 16:10
-
Oli Bartsch voted on patch set 7 CR +2 V +2 10/22/26, 16:25
-
Oli Bartsch merged patch set 8 10/22/26, 16:25