Review main Merged

96916[BUGFIX] Use shared language selector in recycler and record history

Oli Bartsch CR +2 V +2 Hard +322 −87 updated 10/22/26, 16:25

Commit message

The recycler module and the record history built their own
language dropdowns instead of using LanguageSelectorBuilder like
the Layout and Records modules.

A new LanguageSelectorBuilder::buildForSiteLanguages() builds a
single-select dropdown for the given site languages, optionally
with an entry for all languages. The recycler uses it with that
entry, so a single language remains selectable with one click.
The record history uses it without that entry, offering the
languages the record is translated to, as before.

While a language is selected in the recycler, records valid in
all languages and records of tables without language support are
now listed as well, as in the Records module, instead of being
omitted.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 13

Review log 1924

  1. Oli Bartsch uploaded patch set 1 10/20/26, 12:58

  2. Oli Bartsch updated the commit message in patch set 2 10/20/26, 13:04

  3. Oli Bartsch updated the commit message in patch set 3 10/20/26, 13:04

  4. core-ci voted on patch set 3 V +1 10/20/26, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111819

  5. Garvin Hicking commented on patch set 3 V -1 10/20/26, 14:03

    Now I can no longer see "only german" records, because the english language is not unselectable
  6. Oli Bartsch uploaded patch set 4 V +1 10/20/26, 16:44

  7. Oli Bartsch commented on patch set 4 10/20/26, 16:55

    Reply

    I've fixed this.
  8. core-ci voted on patch set 4 V +1 10/20/26, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111894

  9. Simon Schaufelberger commented on patch set 4 10/20/26, 17:23

    LanguageSelectorBuilder.php:55

    extract count into a variable, otherwise the calculation needs to happen 2x. micro-optimization only.

    LanguageSelectorBuilder.php:149

    same here

    LanguageSelectorBuilder.php:177

    shouldn't we use `translate` from now on?
  10. Garvin Hicking commented on patch set 4 10/20/26, 18:04

    Reply

    (Talked about this - I believe it must be easier for a user to pick a single language without page reloads or needing to first "uncheck all" only to be able to select a single language. Especially for sites with more languages I think the recycler is usually opened to filter for a specific single language not multiple ones. Having said that, I understand the need to unify the language selector to be in line with the appearance of the other ones)
  11. Oli Bartsch uploaded patch set 5 V +1 10/20/26, 18:28

  12. Oli Bartsch uploaded patch set 6 10/20/26, 18:37

  13. Oli Bartsch commented on patch set 6 10/20/26, 18:42

    Reply

    I gave up. Let's go with your UI but using the Builder. Fine?
  14. Garvin Hicking commented on patch set 6 10/20/26, 18:46

    Reply

    Happily so. Appreciate the effort! Your agent's place, or mine? ;)
  15. core-ci voted on patch set 5 V +1 10/20/26, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111909

  16. core-ci voted on patch set 6 V +1 10/20/26, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111913

  17. Oli Bartsch uploaded patch set 7 V +1 10/20/26, 18:57

  18. Garvin Hicking commented on patch set 7 CR +1 V +1 10/20/26, 19:01

    LanguageSelectorBuilder.php:55 Reply

    Done

    LanguageSelectorBuilder.php:149 Reply

    Done

    LanguageSelectorBuilder.php:177 Reply

    Done
  19. Garvin Hicking commented on patch set 7 10/20/26, 19:01

    Reply

    Done
  20. Oli Bartsch commented on patch set 7 10/20/26, 19:02

    Reply

    We are all set. 🚀

    LanguageSelectorBuilder.php:55 Reply

    Done

    LanguageSelectorBuilder.php:149 Reply

    Done

    LanguageSelectorBuilder.php:177 Reply

    Done
  21. core-ci voted on patch set 7 V +1 10/20/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111921

  22. Benni Mack voted on patch set 7 CR +1 V +1 10/22/26, 16:10

  23. Oli Bartsch voted on patch set 7 CR +2 V +2 10/22/26, 16:25

  24. Oli Bartsch merged patch set 8 10/22/26, 16:25