Review 14.3 Merged

96919[BUGFIX] Allow expanding inline records in dotted FlexForm fields

Garvin Hicking CR +2 V +2 Normal +135 −2 updated 10/20/26, 14:17

Commit message

Inline and file reference records could not be expanded when the
FlexForm field identifier contains a dot, e.g. "settings.image".

The dot ends up in the id of the collapsible panel, and the toggle
button referenced it via data-bs-target="#…". Bootstrap passes that
value unescaped to querySelector(), which treats the dot as a class
selector, so no element is found and nothing happens on click.

The toggle now uses an attribute selector [id="…"], which matches
the id verbatim, including dots.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Garvin Hicking commented on patch set 1 10/20/26, 14:05

    Cherry Picked from branch main.
  2. Garvin Hicking commented on patch set 2 10/20/26, 14:06

    Published edit on patch set 1.
  3. core-ci voted on patch set 2 V +1 10/20/26, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111841

  4. core-ci voted on patch set 1 V -1 10/20/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111840

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 10/20/26, 14:17

  6. Garvin Hicking merged patch set 3 10/20/26, 14:17