Review main Merged Breaking

96971[!!!][TASK] Sharpen GD, IM and GM on one even scale

Benjamin Kott CR +2 V +2 Normal +119 −5 updated 10/23/26, 08:40

Commit message

GraphicalFunctions::v5_sharpen() still gave ImageMagick and
GraphicsMagick -sharpen 1x2 to -sharpen 5x5, another scale than
GraphicsCanvas::sharpen(). It now returns -unsharp 1x2+(n*0.25)+0 for
step n, the scale GD sharpens on, whose step 1 is what GFX/sharpen
applies.

GD steps by 9/128 instead of 1/16, which matches ImageMagick and
GraphicsMagick more closely and is still a binary fraction, so its
kernel adds up to exactly 1 and leaves flat areas alone.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 69

  1. Benjamin Kott uploaded patch set 1 10/21/26, 12:05

  2. core-ci voted on patch set 1 V +1 10/21/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112005

  3. Benjamin Kott rebased onto patch set 2 V +1 10/21/26, 17:33

  4. core-ci voted on patch set 2 V +1 10/21/26, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112025

  5. Benjamin Kott rebased onto patch set 3 V +1 10/22/26, 18:42

  6. core-ci voted on patch set 3 V +1 10/22/26, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112170

  7. Benni Mack voted on patch set 3 CR +1 V +1 10/23/26, 08:00

  8. Benjamin Kott voted on patch set 3 CR +2 V +2 10/23/26, 08:40

  9. Benjamin Kott merged patch set 4 10/23/26, 08:40